Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: bloom-builder deployment created always #14090

Closed
z0rc opened this issue Sep 10, 2024 · 0 comments · Fixed by #14128
Closed

helm: bloom-builder deployment created always #14090

z0rc opened this issue Sep 10, 2024 · 0 comments · Fixed by #14128

Comments

@z0rc
Copy link

z0rc commented Sep 10, 2024 •
edited
Loading

Describe the bug
bloom-builder deployment is created always, even when it's set to 0 replicas (default).

To Reproduce
Steps to reproduce the behavior:

  1. deploy helm chart with distributed mode and default values
  2. bloom-builder deployment is present

Expected behavior
bloom-builder deployment should be created only when it has more than 1 replica, just like any other loki component. Like this https://github.com/grafana/loki/blob/main/production/helm/loki/templates/bloom-planner/statefulset-bloom-planner.yaml#L3

Alternatively deployment should be created only when this component is actually enabled though config.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm

Screenshots, Promtail config, or terminal output
N/A
@z0rc z0rc mentioned this issue Sep 10, 2024
Merged
7 tasks
@chaudum chaudum mentioned this issue Sep 12, 2024
Merged
7 tasks
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
@chaudum
fix(helm): Various fixes and enhancements for bloom components (grafa…
326e005 
…na#14128)

* Fix: Do not create bloom Deployment/Statefulset if replicas=0 (fixes grafana#14090)
* Fix: Configure PV claims for bloom gateway and bloom builder correctly (fixes grafana#14082)
* Fix: Configure emphemeral storage for bloom builder working directory (fixes grafana#14084)
* Add required configuration for bloom builder and bloom gateway

---

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(helm): Various fixes and enhancements for bloom components grafana/loki
1 participant
@z0rc