Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run promtail as a service from an installation package. #1790

Closed
wardbekker opened this issue Mar 10, 2020 · 2 comments
Closed

Run promtail as a service from an installation package. #1790

wardbekker opened this issue Mar 10, 2020 · 2 comments
Labels
component/agent component/packaging stale A stale issue or PR that will automatically be closed. type/enhancement Something existing could be improved

Comments

@wardbekker
Copy link
Member

wardbekker commented Mar 10, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Promtail is now a binary release. If you want to run it as a service, you need to create and register the service definitions yourself. For non-k8s installs, users very likely want to run promtail as a service.

Describe the solution you'd like
Provide installation packages for all major operating systems that will install promtail as a service.

Describe alternatives you've considered
Self scripting the service definitions. However, providing promtail as a service will improve onboarding and increase Loki adoption

** Relevant Resources / projects **
https://github.com/kardianos/service
https://github.com/jordansissel/fpm
@stale
Copy link

stale bot commented Apr 9, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Apr 9, 2020
@stale stale bot closed this as completed Apr 16, 2020
@slim-bean
Copy link
Collaborator

Duplicate of #52

@slim-bean slim-bean marked this as a duplicate of #52 Jan 5, 2021
cyriltovena added a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@cyriltovena @gouthamve
Fixes store duplicate label names and values. (grafana#1790)
3c7f46b 
* Fixes store label name and values duplicate.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Normalize string unicity control

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Adds benchmark to compare the new unique algorithm

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/agent component/packaging stale A stale issue or PR that will automatically be closed. type/enhancement Something existing could be improved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wardbekker @slim-bean