Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API Endpoint to get Loki version #3221

Closed
loganmc10 opened this issue Jan 24, 2021 · 5 comments · Fixed by #3972
Closed

HTTP API Endpoint to get Loki version #3221

loganmc10 opened this issue Jan 24, 2021 · 5 comments · Fixed by #3972
Assignees
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@loganmc10
Copy link

Is your feature request related to a problem? Please describe.
Prometheus has this endpoint: GET /api/v1/status/buildinfo which will return the version of Prometheus. I don't see any way using Loki's HTTP API to figure out what version of Loki I'm talking to.

Describe the solution you'd like
GET /api/v1/status/buildinfo or alternative for Loki.

Additional context
I'm using Grafana Cloud, so I don't have any access or control over the Loki server. I don't know what version of Loki I'm using, I'd like to know so that I know when I can use new features that become available.

@owen-d
Copy link
Member

owen-d commented Jan 26, 2021

I like this request. One thing to note is that Grafana Cloud uses it's own internal release schedule which doesn't exactly correspond to Loki releases. However, Loki releases tend to be based on these internal builds which are then tagged & released as x.y.z. These tend to be the k<xx> branches here: https://github.com/grafana/loki/branches/all?query=k

I think we should expose this information, but having a commit hash and a k<xx> returned to you (in the case of Grafana Cloud) may not be the most helpful :(

@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 20, 2021
@loganmc10
Copy link
Author

Stalebot this is a really good idea, I promise

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Mar 20, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@loganmc10
Copy link
Author

Plz stalebot have mercy on me

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@owen-d owen-d added keepalive An issue or PR that will be kept alive and never marked as stale. beginner-friendly good first issue These are great first issues. If you are looking for a place to start, start here! labels Jul 8, 2021
jeschkies added a commit to jeschkies/loki that referenced this issue Jul 8, 2021
owen-d pushed a commit that referenced this issue Jul 9, 2021
* Return build info under `/version`.

Closes #3221

* Update documentation.

* Correct docs.

* Format version handler code.

* Ignore write error.

* Sort imports.

* Use `PrometheusVersion` struct.

* Set Go version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants