Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

30d queries seems to be broken on the frontend #3541

Closed
cyriltovena opened this issue Mar 25, 2021 · 0 comments · Fixed by #3550
Closed

30d queries seems to be broken on the frontend #3541

cyriltovena opened this issue Mar 25, 2021 · 0 comments · Fixed by #3550
Labels
keepalive An issue or PR that will be kept alive and never marked as stale. type/bug Somehing is not working as expected

Comments

@cyriltovena
Copy link
Contributor

Describe the bug
30d queries are not working while 7d+ are. See below.

image
image
@cyriltovena cyriltovena added keepalive An issue or PR that will be kept alive and never marked as stale. kind/bug labels Mar 25, 2021
cyriltovena added a commit to cyriltovena/loki that referenced this issue Mar 26, 2021
@cyriltovena
Fixes a bug in MatrixStepper when sharding queries.
30dc2d6 
Since we split correctly metric queries, this bug has show itself.
Basically we were not correctly stepping through time. We should always start from start, add the step until the start is after the end.

For more read: https://www.robustperception.io/step-and-query_range

Fixes grafana#3541

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena mentioned this issue Mar 26, 2021
Merged
cyriltovena added a commit that referenced this issue Mar 29, 2021
@cyriltovena
Fixes a bug in MatrixStepper when sharding queries. (#3550)
b11d2ef 
* Fixes a bug in MatrixStepper when sharding queries.

Since we split correctly metric queries, this bug has show itself.
Basically we were not correctly stepping through time. We should always start from start, add the step until the start is after the end.

For more read: https://www.robustperception.io/step-and-query_range

Fixes #3541

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Fixes tests.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Fixes tests. for real.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Not easy to get those test working.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
slim-bean pushed a commit that referenced this issue Apr 6, 2021
@cyriltovena @slim-bean
Fixes a bug in MatrixStepper when sharding queries. (#3550)
b2aec4a 
* Fixes a bug in MatrixStepper when sharding queries.

Since we split correctly metric queries, this bug has show itself.
Basically we were not correctly stepping through time. We should always start from start, add the step until the start is after the end.

For more read: https://www.robustperception.io/step-and-query_range

Fixes #3541

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Fixes tests.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Fixes tests. for real.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Not easy to get those test working.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
(cherry picked from commit b11d2ef)
@chaudum chaudum added the type/bug Somehing is not working as expected label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keepalive An issue or PR that will be kept alive and never marked as stale. type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a bug in MatrixStepper when sharding queries. cyriltovena/loki
2 participants
@chaudum @cyriltovena