Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logcli query: provider -f/--follow as alias for --tail #3570

Closed
invidian opened this issue Apr 1, 2021 · 7 comments · Fixed by #4203
Closed

logcli query: provider -f/--follow as alias for --tail #3570

invidian opened this issue Apr 1, 2021 · 7 comments · Fixed by #4203

Comments

@invidian
Copy link
Contributor

invidian commented Apr 1, 2021

Is your feature request related to a problem? Please describe.

When using tail, which I assume --tail flags refers to, by default get only the last N lines of the file. If you add -f or --follow, you continuously follow the content appearing to the end of the file.

To provide better UX for system administrators, it would be nice to have a consistent UX between tail and logcli query, which shares some functionality.

Describe the solution you'd like

I propose to either add an alias for --tail option as --follow or use it to replace --tail option all together, as I think it's name is confusing right now. logcli query behavior is tail-like by default (get last N log lines).
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@invidian
Copy link
Contributor Author

invidian commented Jun 2, 2021

2 months without any response 😢

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@stale
Copy link

stale bot commented Jul 9, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jul 9, 2021
@invidian
Copy link
Contributor Author

invidian commented Jul 9, 2021

Still relevant.

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jul 9, 2021
@stale
Copy link

stale bot commented Aug 21, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Aug 21, 2021
@invidian
Copy link
Contributor Author

Not stale please

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Aug 21, 2021
@invidian invidian mentioned this issue Aug 23, 2021
Merged
2 tasks
@invidian
Copy link
Contributor Author

Created #4203 to address it.

invidian added a commit to invidian/loki that referenced this issue Aug 23, 2021
@invidian
cmd/logcli: add --follow flag as an alias for --tail
0a81fba 
When using 'logcli query --tail', '--tail' behaves similar to the 'tail'
command, which uses '--follow' flag, if you want to continuously
follow the appended data to the file.

I believe '--follow' flag is more natural for system administrators to
use rather than '--tail' if one wants to "follow" the incoming logs, so
this commit adds one, as an alias for '--tail'.

Closes grafana#3570

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
dannykopping pushed a commit that referenced this issue Aug 23, 2021
@invidian
cmd/logcli: add --follow flag as an alias for --tail (#4203)
b3df9f5 
When using 'logcli query --tail', '--tail' behaves similar to the 'tail'
command, which uses '--follow' flag, if you want to continuously
follow the appended data to the file.

I believe '--follow' flag is more natural for system administrators to
use rather than '--tail' if one wants to "follow" the incoming logs, so
this commit adds one, as an alias for '--tail'.

Closes #3570

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/logcli: add --follow flag as an alias for --tail invidian/loki
1 participant
@invidian