Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure Blob Storage with Managed Identity #4256

Closed
sandy2008 opened this issue Sep 1, 2021 · 8 comments
Closed

Add support for Azure Blob Storage with Managed Identity #4256

sandy2008 opened this issue Sep 1, 2021 · 8 comments

Comments

@sandy2008
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • Add support for constantly get Bearer Token & get the bulks with the Token.
@sandy2008
Copy link
Contributor Author

sandy2008 commented Sep 1, 2021

Example:

package main

import (
	"fmt"
	"github.com/Azure/go-autorest/autorest/adal"
)

func main() {
	msiEndpoint, _ := adal.GetMSIVMEndpoint()

	var spt *adal.ServicePrincipalToken
	var err error
	
	var resource string = "https%3A%2F%2Fstorage.azure.com%2F"
	
	spt, err = adal.NewServicePrincipalTokenFromMSI(msiEndpoint, resource)
	
	fmt.Println(spt)
	fmt.Println(err)
}

@stale
Copy link

stale bot commented Oct 2, 2021

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 2, 2021
@tomasfreund
Copy link

I'd also like if there was an option to select the managed identity to use by client id. This is required when an AKS cluster has multiple identities, you need to specify which one to use or it fails.

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Dec 9, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 9, 2022
@Ottovsky
Copy link

Any chance Loki will get Azure MSI support?

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jan 21, 2022
@sandy2008
Copy link
Contributor Author

Any chance Loki will get Azure MSI support?

Already submitted PR & merged.
#4858

@tomasfreund
Copy link

It seems that the PR does not allow to select the managed identity to use. This can cause issues when the cluster has multiple managed identities.

@Ottovsky
Copy link

Yes, without ability to define User Assigned ID, it will make it hard to use it together with https://github.com/Azure/aad-pod-identity in the AKS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants