-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add ManagedIdentity in Azure Blob Storage #4858
Conversation
sandy2008
commented
Dec 2, 2021
- Support Using ManagedIdentity in Azure Blob Storage
wow, this looks super useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits
looking forward to this feature, want to use that on our AKS clusters |
Can you run |
Sorry I was little busy recently, I am wrapping it up! |
Thx, I fixed all of them. |
@DylanGuedes @cyriltovena Please kindly review it again when you got time. |
can‘t wait for this to be merged 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit but LGTM! (I'm not a maintainer, though)
return nil, err | ||
} | ||
|
||
// defing the Azure Pipeline Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM