Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Issue with loki service in singleBinary #7260

Closed
fyannk opened this issue Sep 27, 2022 · 4 comments · Fixed by #7301
Closed

[Helm] Issue with loki service in singleBinary #7260

fyannk opened this issue Sep 27, 2022 · 4 comments · Fixed by #7301

Comments

@fyannk
Copy link

fyannk commented Sep 27, 2022

Describe the bug
Fresh install through Helm Chart of single binary is not working when going through deffault service.

Currently we have here:

  selector:
    {{- include "loki.selectorLabels" . | nindent 4 }}

And we should have:

  selector:
    {{- include "loki.singleBinarySelectorLabels" . | nindent 4 }}

Hence, service point to all instances created by Helm Chart, Canary included !

Promtail cannot push logs and Grafana cannot read them

To Reproduce
Fresh install the solution with values:

loki:
  storage:
      type: 'filesystem'
    rulerConfig:
      storage:
        type: local

Expected behavior
Included default service should be working

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm

Logs

level=error ts=2022-09-27T11:18:17.537024173Z caller=client.go:380 component=client host=loki:3100 msg="final error sending batch" status=404 error="server returned HTTP status 404 Not Found (404): 404 page not found"
level=error ts=2022-09-27T11:18:18.337102338Z caller=client.go:380 component=client host=loki:3100 msg="final error sending batch" status=404 error="server returned HTTP status 404 Not Found (404): 404 page not found"
@jeschkies
Copy link
Contributor

@fyannk thanks. Would you mind creating a PR? You've seemed to nailed down the issue already 🙂

@besteban1989
Copy link
Contributor

I'm running with the same issue, @fyannk your solution works, I updated the kubernetes service manually, also created the PR. @jeschkies can you help us reviewing the PR ?

Thanks.

vlad-diachenko pushed a commit that referenced this issue Oct 5, 2022
Single binary deployment is not working when going through default
service. The issue is with the labels that currently includes the canary
pods.

Fixes #7260
@besteban1989
Copy link
Contributor

@vlad-diachenko can we have a new helm chart version? If you can add a new version will be very helpful. Thanks.

lxwzy pushed a commit to lxwzy/loki that referenced this issue Nov 7, 2022
Single binary deployment is not working when going through default
service. The issue is with the labels that currently includes the canary
pods.

Fixes grafana#7260
changhyuni pushed a commit to changhyuni/loki that referenced this issue Nov 8, 2022
Single binary deployment is not working when going through default
service. The issue is with the labels that currently includes the canary
pods.

Fixes grafana#7260
@vlad-diachenko
Copy link
Contributor

@vlad-diachenko can we have a new helm chart version? If you can add a new version will be very helpful. Thanks.

Hey @besteban1989 . sorry for the delay. yes, I released the new version of helm chart at the moment when I merged the PR... so, you can use the latest chart, the changes are there....

Abuelodelanada pushed a commit to canonical/loki that referenced this issue Dec 1, 2022
Single binary deployment is not working when going through default
service. The issue is with the labels that currently includes the canary
pods.

Fixes grafana#7260
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
Single binary deployment is not working when going through default
service. The issue is with the labels that currently includes the canary
pods.

Fixes grafana#7260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants