Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki microservices Tanka: error during manifest generation #9361

Closed
irizzant opened this issue May 2, 2023 · 2 comments · Fixed by #9362
Closed

Loki microservices Tanka: error during manifest generation #9361

irizzant opened this issue May 2, 2023 · 2 comments · Fixed by #9362

Comments

@irizzant
Copy link
Contributor

irizzant commented May 2, 2023

Describe the bug
There is an error during manifest generation with the following options:

memberlist_ring_enabled: true,
create_service_monitor: true,

The error is:
Error: evaluating jsonnet: RUNTIME ERROR: Field does not exist: name /home/ivan.rizzante/kubernetes/gitops/loki/vendor/loki/servicemonitor.libsonnet:42:13-42 thunk from <object <anonymous>> Array element 3 Field "values" Array element 0 Field "matchExpressions" Field "selector" Field "spec" Field "serviceMonitor" During manifestation

To Reproduce
Steps to reproduce the behavior:

  1. Started Loki 2.8.1
  2. Set configuration parameters as above
  3. Render jsonnet manifests with tk show

Expected behavior
I should be able to generate the manifests

Environment:

  • Infrastructure: kubernetes
  • Deployment tool: jsonnet

Screenshots, Promtail config, or terminal output
If applicable, add any output to help explain your problem.
@irizzant irizzant mentioned this issue May 2, 2023
Merged
5 tasks
DylanGuedes pushed a commit that referenced this issue May 4, 2023
@irizzant
Loki microservices Tanka: fix error during manifest generation (#9362)
3478e18 
**What this PR does / why we need it**:
Fixes an error on the ServiceMonitor generated when
```
memberlist_ring_enabled: true,
create_service_monitor: true,
```
It also adds some checks on `memberlist.libsonnet` to avoid generating
invalid kubernetes manifests.

**Which issue(s) this PR fixes**:
Fixes #9361
aminesnow pushed a commit to aminesnow/loki that referenced this issue May 4, 2023
@irizzant
Loki microservices Tanka: fix error during manifest generation (grafa…
e12dea6 
…na#9362)

**What this PR does / why we need it**:
Fixes an error on the ServiceMonitor generated when
```
memberlist_ring_enabled: true,
create_service_monitor: true,
```
It also adds some checks on `memberlist.libsonnet` to avoid generating
invalid kubernetes manifests.

**Which issue(s) this PR fixes**:
Fixes grafana#9361
@irizzant
Copy link
Contributor Author

irizzant commented May 9, 2023

Hi @DylanGuedes ,
do you know when these changes will be released (I mean in a stable release not master)?

Thanks

@DylanGuedes
Copy link
Contributor

Hi @DylanGuedes , do you know when these changes will be released (I mean in a stable release not master)?

Thanks

Not sure, but probably less than 2 months (2.9 release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loki microservices Tanka: fix error during manifest generation
2 participants
@DylanGuedes @irizzant