Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drone(docker-driver): Fetch tags before pushing image during release #10664

Merged
merged 5 commits into from
Sep 21, 2023
Merged

drone(docker-driver): Fetch tags before pushing image during release #10664

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2133c29
drone(docker-driver): Fetch tags before pushing image during release
kavirajk Sep 21, 2023
c73adfb
add explicit command
kavirajk Sep 21, 2023
b7bbd42
add back drone key
kavirajk Sep 21, 2023
adcd46d
jsonnetfmt
kavirajk Sep 21, 2023
5fbea29
Sign drone.yml
kavirajk Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .drone/drone.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ local logql_analyzer() = pipeline('logql-analyzer') + arch_image('amd64') {
depends_on: ['check'],
};


local multiarch_image(arch) = pipeline('docker-' + arch) + arch_image(arch) {
steps+: [
// dry run for everything that is not tag or main
Expand Down Expand Up @@ -917,6 +916,7 @@ local manifest_ecr(apps, archs) = pipeline('manifest-ecr') {
DOCKER_PASSWORD: { from_secret: docker_password_secret.name },
},
commands: [
'git fetch origin --tags',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried one more approach before this.

Tried to add it as separate step say fetch-git-tags on this pipeline. In that case, git tags only fetched in that particular step and cannot be used during make docker-driver-push step. Rationale being other pipelines that do use separate step to fetch git tags, stores it in ./tools/image-tag > arch.tags and re-use it other step.

Ended up doing this way without changing much of the pipelines.

'make docker-driver-push',
],
volumes: [
Expand Down
6 changes: 1 addition & 5 deletions .drone/drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,6 +1743,7 @@ kind: pipeline
name: docker-driver
steps:
- commands:
- git fetch origin --tags
- make docker-driver-push
depends_on:
- clone
Expand Down Expand Up @@ -2014,8 +2015,3 @@ get:
path: infra/data/ci/packages-publish/gpg
kind: secret
name: gpg_private_key
---
kavirajk marked this conversation as resolved.
Show resolved Hide resolved
kind: signature
hmac: 6aff5ae73eeaed171dafbc08b599abaf9a4ef4c1d68212da1a1442f36f5c7d8b

...