drone(docker-driver): Fetch tags before pushing image during release #10671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10664) **What this PR does / why we need it**: We realized, loki-docker-driver image was not being pushed after 2.8.2. And looking into it's drone pipeline and comparing it with other steps, docker-driver step is not fetching the tags,[ thus the final hash calculated to push is some HEAD branch.](https://github.com/grafana/loki/blob/main/tools/image-tag#L13-L14) e.g: even if we have tag 2.9.1, it pushes only with latest HEAD commit hash. This PR fixes it.    **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: I would prefer this instead of #10663. Because that would make fetching tags more repetitive in all the drone tasks (can also be expensive in terms of running time if we put all together) **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) --------- Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 8721e41)
MichelHollands
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #10664 to
2.9.xbranch