operator: Allow endpoint_suffix in azure object storage secret #10715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+59
to
+60
| // Extract and validate optional fields | ||
| endpointSuffix := s.Data["endpoint_suffix"] |
There was a problem hiding this comment.
I'm a bit confused by the comment, we are only extracting the field correct?
There was a problem hiding this comment.
It's just a hint to make the section more human readable. I imagine that we extra more optional fields if requested.
xperimental
reviewed
Oct 2, 2023
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
xperimental
approved these changes
Oct 2, 2023
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…na#10715) Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable using LokiStack with Azure Blob Storage behind a private endpoint.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR