Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Add missing marker/sweeper panels in retention dashboard #10854

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Oct 11, 2023

What this PR does / why we need it:
When we imported the loki-mixin in #9468 we accidentally removed the per-table marker and sweeper panels from the retention dashboards. With these panels the LokiStack administrator can have a full overview when retention policies are applied.

Per-Table Marker panels:

image

Sweeper panels:

image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@periklis periklis self-assigned this Oct 11, 2023
@periklis periklis requested review from xperimental and a team as code owners October 11, 2023 10:25
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but lgmt

operator/jsonnet/config.libsonnet Show resolved Hide resolved
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately did not get the panels to display proper data in my short test run, but everything looks fine. 👍

@periklis periklis merged commit 48087e0 into grafana:main Oct 12, 2023
9 checks passed
periklis added a commit to periklis/loki that referenced this pull request Oct 12, 2023
periklis added a commit to openshift/loki that referenced this pull request Oct 12, 2023
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants