-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add missing marker/sweeper panels in retention dashboard #10854
Merged
periklis
merged 6 commits into
grafana:main
from
periklis:operator-missing-retention-panels
Oct 12, 2023
Merged
operator: Add missing marker/sweeper panels in retention dashboard #10854
periklis
merged 6 commits into
grafana:main
from
periklis:operator-missing-retention-panels
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested, but lgmt
xperimental
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately did not get the panels to display proper data in my short test run, but everything looks fine. 👍
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 12, 2023
…rafana#10854) Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 12, 2023
[release-5.8] Backport PR grafana#10854
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…rafana#10854) Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we imported the loki-mixin in #9468 we accidentally removed the per-table marker and sweeper panels from the retention dashboards. With these panels the LokiStack administrator can have a full overview when retention policies are applied.
Per-Table Marker panels:
Sweeper panels:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PR