Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: Fix self monitoring with default configuration by conditionally setting X-Org-ID header on gateway #10875

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Helm: Fix self monitoring with default configuration by conditionally setting X-Org-ID header on gateway #10875

wants to merge 5 commits into from
+14 −4

Conversation

bossm8
Copy link

@bossm8 bossm8 commented Oct 12, 2023

What this PR does / why we need it:

This fixes the default configuration to allow selfMonitoring to push logs to loki via the gateway when loki.auth_enabled is true by setting the X-Scope-OrgID header only if it is not present.

Which issue(s) this PR fixes:
Fixes (partially) #10873

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

bossm8 and others added 3 commits October 12, 2023 15:57
@bossm8 bossm8 requested a review from a team as a code owner October 12, 2023 14:10
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bossm8 @CLAassistant