Helm: Removed extra check preventing Grafana dashboards from getting created #10902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
itay-grudev
changed the title
…ds from getting created. Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
|
I rebased and updated the PR with the changes required since the recent loki release. |
MichelHollands
approved these changes
Oct 17, 2023
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…created (grafana#10902) **What this PR does / why we need it**: Fixes a bug in the Loki Helm chart that prevents Grafana dashboards from getting created when external storage (`s3/gcs/azure`) isn't used or when in `singleBinary` mode. With this change dashboard creation is controlled solely by the `.Values.monitoring.dashboards.enabled` flag. **Which issue(s) this PR fixes**: Fixes grafana#10885 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) --------- Signed-off-by: Itay Grudev <itay.grudev@essentim.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…created (grafana#10902) **What this PR does / why we need it**: Fixes a bug in the Loki Helm chart that prevents Grafana dashboards from getting created when external storage (`s3/gcs/azure`) isn't used or when in `singleBinary` mode. With this change dashboard creation is controlled solely by the `.Values.monitoring.dashboards.enabled` flag. **Which issue(s) this PR fixes**: Fixes grafana#10885 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e) --------- Signed-off-by: Itay Grudev <itay.grudev@essentim.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a bug in the Loki Helm chart that prevents Grafana dashboards from getting created when external storage (
s3/gcs/azure) isn't used or when insingleBinarymode.With this change dashboard creation is controlled solely by the
.Values.monitoring.dashboards.enabledflag.Which issue(s) this PR fixes:
Fixes #10885
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR