Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve table manager documentation #1099

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Oct 2, 2019

What this PR does / why we need it:

Following a personal interest to better understand how the table manager works, I spent few hours reading the code and trying to document what I've understood. I would be glad if you could take a look to make sure I've not done any terrible mistake.

Checklist

  • Documentation added
  • Tests updated

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! I have two extremely minor grammar nitpicks, but this LGTM and is ready to merge.

docs/operations/storage/table-manager.md Outdated Show resolved Hide resolved
docs/operations/storage/table-manager.md Outdated Show resolved Hide resolved
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rfratto rfratto merged commit 7ac9e4a into grafana:master Oct 2, 2019
@pracucci pracucci deleted the improve-table-manager-doc branch October 2, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants