Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.9.x] fix: respect query matcher in ingester when getting label values (#10375) #11056

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[release-2.9.x] fix: respect query matcher in ingester when getting label values (#10375) #11056

merged 1 commit into from
Nov 6, 2023

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Oct 26, 2023 •
edited
Loading

What this PR does / why we need it:
This PR is a backport of #10375 to release-2.9.x
Which issue(s) this PR fixes:
Relates to #10759

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory.

@JoaoBraveCoding JoaoBraveCoding requested a review from a team as a code owner October 26, 2023 16:46
@JoaoBraveCoding JoaoBraveCoding changed the title [release-2.9.x] fix: respect query matcher in ingester when getting label values (https://github.com/grafana/loki/pull/10375) [release-2.9.x] fix: respect query matcher in ingester when getting label values (#10375) Oct 26, 2023
dannykopping
dannykopping approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@periklis periklis merged commit b9a7151 into grafana:release-2.9.x Nov 6, 2023
4 checks passed
@JoaoBraveCoding JoaoBraveCoding deleted the backport-10375-to-release-2.9.x branch January 31, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoBraveCoding @dannykopping @periklis