Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix per-pod panel unit (from 'ms' to 's') #11245

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
Change per-pod latency panel unit from 'ms' to 's' (the metric is in the 's' unit)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner November 16, 2023 14:21
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@DylanGuedes DylanGuedes merged commit 4309add into main Nov 16, 2023
9 checks passed
@DylanGuedes DylanGuedes deleted the fix-panel-unit-to-s branch November 16, 2023 19:59
jeschkies pushed a commit that referenced this pull request Nov 21, 2023
**What this PR does / why we need it**:
Change per-pod latency panel unit from 'ms' to 's' (the metric is in the 's' unit)
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
**What this PR does / why we need it**:
Change per-pod latency panel unit from 'ms' to 's' (the metric is in the 's' unit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants