Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Allows to configure client_max_body_size and location blocks #11279

Closed
wants to merge 0 commits into from

Conversation

panzouh
Copy link

@panzouh panzouh commented Nov 21, 2023

What this PR does / why we need it:

Adjusting client_max_body_size in Nginx could allow me fixing nginx errors client intended to send too large body.
Adjusting location snippets would allow me to add custom headers on individual endpoints, ensuring tailored optimizations where needed.

Which issue(s) this PR fixes:
Fixes #10521

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@panzouh panzouh requested a review from a team as a code owner November 21, 2023 11:00
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Trivy scan found the following vulnerabilities:

@JStickler
Copy link
Contributor

Please note this bullet from the checklist: For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

You need to update the chart version in ALL of the files listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to update a default config on the loki-gateway nginx config?
3 participants