-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Fix custom CA for object-store in ruler component #11288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
changed the title
fix: Add custom objstore SA for ruler component
operator: fix: Add custom objstore SA for ruler component
Nov 22, 2023
periklis
changed the title
operator: fix: Add custom objstore SA for ruler component
operator: Add custom objstore SA for ruler component
Nov 22, 2023
Trivy scan found the following vulnerabilities:
|
xperimental
changed the title
operator: Add custom objstore SA for ruler component
operator: Fix custom CA for object-store in ruler component
Nov 22, 2023
xperimental
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should fix the issue, though I did not get to testing this in a cluster yet. One small nitpick.
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
xperimental
approved these changes
Nov 23, 2023
periklis
added a commit
to periklis/loki
that referenced
this pull request
Nov 23, 2023
…11288) Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Nov 23, 2023
…11288) Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Nov 23, 2023
…11288) Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis
added a commit
to openshift/loki
that referenced
this pull request
Nov 24, 2023
[release-5.6] Backport PR grafana#11288
openshift-merge-bot bot
added a commit
to openshift/loki
that referenced
this pull request
Nov 24, 2023
[release-5.7] Backport PR grafana#11288
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…11288) Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix assigning custom CA bundle volume/volumeMount to ruler statefulset for object storage operations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR