Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Fix custom CA for object-store in ruler component #11288

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

periklis
Copy link
Collaborator

What this PR does / why we need it:
Fix assigning custom CA bundle volume/volumeMount to ruler statefulset for object storage operations.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Nov 22, 2023
@periklis periklis requested review from xperimental and a team as code owners November 22, 2023 10:36
@periklis periklis changed the title fix: Add custom objstore SA for ruler component operator: fix: Add custom objstore SA for ruler component Nov 22, 2023
@periklis periklis changed the title operator: fix: Add custom objstore SA for ruler component operator: Add custom objstore SA for ruler component Nov 22, 2023
Copy link
Contributor

github-actions bot commented Nov 22, 2023

Trivy scan found the following vulnerabilities:

@xperimental xperimental changed the title operator: Add custom objstore SA for ruler component operator: Fix custom CA for object-store in ruler component Nov 22, 2023
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should fix the issue, though I did not get to testing this in a cluster yet. One small nitpick.

operator/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
@periklis periklis enabled auto-merge (squash) November 23, 2023 14:30
@periklis periklis merged commit 6b944f7 into grafana:main Nov 23, 2023
14 checks passed
periklis added a commit to periklis/loki that referenced this pull request Nov 23, 2023
…11288)

Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis added a commit to periklis/loki that referenced this pull request Nov 23, 2023
…11288)

Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis added a commit to periklis/loki that referenced this pull request Nov 23, 2023
…11288)

Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis added a commit to openshift/loki that referenced this pull request Nov 24, 2023
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Nov 24, 2023
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
…11288)

Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants