-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add serviceaccount per lokistack resource #11533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoBraveCoding
requested review from
periklis,
xperimental and
a team
as code owners
December 20, 2023 10:33
JoaoBraveCoding
changed the title
Add serviceaccount per lokistack resource
operator: Add serviceaccount per lokistack resource
Dec 20, 2023
8 tasks
Trivy scan found the following vulnerabilities:
|
periklis
reviewed
Dec 20, 2023
periklis
approved these changes
Dec 20, 2023
JoaoBraveCoding
force-pushed
the
lokistack-sa
branch
from
December 20, 2023 18:08
6f49fe4
to
b9d15da
Compare
JoaoBraveCoding
force-pushed
the
lokistack-sa
branch
from
December 20, 2023 18:11
b9d15da
to
150d43e
Compare
periklis
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The lokistack pods used for run using the default serviceaccount on the install namespace except for the lokista-ck-gateway and ruler pods that requested serviceaccounts and corresponding token secrets for external activities (e.g. SubjectAccessReviews, Alertmanager authentication)
The present PR adds a single shared serviceaccount per LokiStack resource to be used by the rest of the components. This enables using the projected account token for authentication against cloud providers (e.g., managed identity services like STS and WIF).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a preparation action for:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR