-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Upgrade k8s.io, sigs.k8s.io and openshift deps #11718
Conversation
cc97ad3
to
e273cc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In tests we specify the type of the pointer (Replicas: ptr.To[int32](2)
) whereas in code we do not (Replicas: ptr.To(opts.Stack.Template.Ingester.Replicas)
), is there any reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we maintain a different go.mod for this package? And why do we maintain both with different versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We export the APIs for other projects to use like prometheus-operator. Currently known user is https://github.com/rhobs/obsctl-reloader/
Constant integers in Golang resolve to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
Upgrade all required dependencies to enable vendoring
openshift/api
fromrelease-4.15
:sigs.k8s.io
:v0.15.3
tov0.16.3
k8s.io
:v1.27.7
tov1.28.6
openshift/api
:release-4.14
torelease-4.15
openshift/library-go
:release-4.14
torelease-4.15
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
github.com/sercand/kuberesolver
is a quick solution to make builds with newergoogle.golang.org/grpc
work again. The module is in the operator's dependency tree because of the direct dependency to Loki.k8.io/utils
bump requires replacing the deprecatedpointer
pkg with it's generic counterpartptr.To
.sigs.k8s.io/controller-runtime
bump requires to move from our custom profiler registration to the one provided by the module.Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR