-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add support for running with Azure Workload Identity #11802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Azure WIF configuration to config file - Configure environment and volumes for Azure WIF - Remove region and subscription_id - Make account_name mandatory for WIF - Set use_federated_token - Set path to token file in environment - Allow overriding Loki image for debugging - Rename client-id and tenent-id environment variables - Use different option in configuration - fixup env vars - Use openshift audience - Add region and subscription_id as environment variables - Add label to Pod when Azure WIF is enabled - Mount federated token to separate directory - Revert "Use openshift audience"
3 tasks
periklis
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Will have a look on a live cluster to get a feeling about it.
periklis
reviewed
Feb 1, 2024
periklis
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for configuring LokiStack to make use of Azure Workload Identity when communicating with the Azure Blob Storage.
Which issue(s) this PR fixes:
LOG-4546
Special notes for your reviewer:
AzureGlobal
environment so far. It might make sense to try to run it in another Azure environment as well to see if the configuration is sufficient.Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updated