Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Allow custom audience for managed-auth on STS #11854

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Feb 1, 2024

What this PR does / why we need it:
Simplify using a custom AWS audience when using STS-based authentication for Loki or fall-back to the default sts.amazonaws.com audience value. In addition use a custom token volume mount to make clear that each pod is using this token for AWS communication only.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Feb 1, 2024
@periklis periklis requested review from xperimental and a team as code owners February 1, 2024 20:02
@periklis periklis changed the title operator: Remove hardcoded audience AWS reqs on STS operator: Allow custom audience for managed-auth on STS Feb 5, 2024
@periklis periklis enabled auto-merge (squash) February 5, 2024 16:38
@periklis periklis merged commit 24c760a into grafana:main Feb 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants