Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Integrate support for OpenShift-managed credentials in Azure #11868

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

xperimental
Copy link
Collaborator

@xperimental xperimental commented Feb 5, 2024

What this PR does / why we need it:

This PR enables the use of "managed authentication" in OpenShift clusters running in Azure.

Which issue(s) this PR fixes:

Implements LOG-4702

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • CHANGELOG.md updated

@xperimental xperimental self-assigned this Feb 5, 2024
@xperimental xperimental requested review from periklis and a team as code owners February 5, 2024 18:29
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit and an ask for clarification on testing.

operator/internal/manifests/storage/configure.go Outdated Show resolved Hide resolved
operator/internal/manifests/storage/configure_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from Peri comments, lgtm

@xperimental xperimental enabled auto-merge (squash) February 6, 2024 17:12
@xperimental xperimental merged commit 6b46e37 into grafana:main Feb 6, 2024
15 checks passed
@xperimental xperimental deleted the azure-wif-cco branch February 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants