-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): Fix encoding of blocked query pattern in configuration #12097
Conversation
operator/internal/manifests/internal/config/loki-runtime-config.yaml
Outdated
Show resolved
Hide resolved
…g.yaml Co-authored-by: Robert Jacob <rojacob@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine during tests. One thing occurred to me, that we might be able to fix in-passing while we are at this spot (see comment).
operator/internal/manifests/internal/config/loki-runtime-config.yaml
Outdated
Show resolved
Hide resolved
operator/internal/manifests/internal/config/loki-runtime-config.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested with a few blocks, seems to work fine 👍
…grafana#12097) Co-authored-by: Robert Jacob <rojacob@redhat.com> Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
What this PR does / why we need it:
Prior to this PR, when LokiStack is configured to block queries with a regex pattern, user could still query logs even when they satisfy the regex pattern. This PR fixes the way that the function
yamlBlock
handles the pattern so that regex works.Which issue(s) this PR fixes:
Fixes LOG-4927
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR