Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k195] fix(ruler): pass noop analyseRules to rules manager #12356

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 774b01d from #12353


What this PR does / why we need it:
Prometheus rules manager calls AnalyseRules to determine the dependents and dependencies of a rule which it then uses to decide if a rule within a group is eligible for concurrent execution.

this pr pass a noop implementation since there is no dependency relation between rules in Loki and uses sequential rule execution.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
if concurrent execution is enabled in the future, RuleDependencyController implementation might need an update to set the dependents and dependencies to false for the rules in a group

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grafanabot grafanabot requested a review from a team as a code owner March 26, 2024 07:46
@grafanabot grafanabot added backport size/M type/bug Somehing is not working as expected labels Mar 26, 2024
@grafanabot grafanabot requested a review from ashwanthgoli March 26, 2024 07:46
@ashwanthgoli ashwanthgoli merged commit 4f3ba4a into k195 Mar 26, 2024
16 checks passed
@ashwanthgoli ashwanthgoli deleted the backport-12353-to-k195 branch March 26, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants