chore: [release-2.9.x] Bump go to 1.21.9 and build image to 0.33.1 #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
MichelHollands
changed the title
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
MichelHollands
changed the title
MichelHollands
changed the title
MichelHollands
requested review from
periklis,
xperimental and
a team
as code owners
8 tasks
poyzannur
reviewed
Apr 5, 2024
poyzannur
reviewed
Apr 5, 2024
| build_image: "grafana/loki-build-image:0.30.1" | ||
| golang_ci_lint_version: "v1.51.2" | ||
| build_image: "grafana/loki-build-image:0.33.1" | ||
| golang_ci_lint_version: "v1.55.1" |
There was a problem hiding this comment.
I guess this downgrade is to be able to work with the linter?
There was a problem hiding this comment.
It's an upgrade. It matches the linter used in the build image now.
poyzannur
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
minor questions just to double check changes.
lgtm, thanks @MichelHollands
This was referenced Apr 8, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use the new build image to address https://pkg.go.dev/vuln/GO-2024-2687.
Some changes had to be made to satisfy the linter.
Fixes https://github.com/grafana/loki-private/issues/940
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR