Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameterise the LogGroupName for lambda-promtail CloudFormation template #12750

Conversation

InsomniaCoder
Copy link
Contributor

What this PR does / why we need it:

while testing #12728 I realised that with the current template, the log group name is hardcoded. so, we cannot refer to this lambda-promtail.yaml from upstream directly but need to copy and make a modification.

paratemerise the log group name will allow us to use directly the upstream template for creating the subscription flow.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@InsomniaCoder InsomniaCoder marked this pull request as ready for review April 23, 2024 21:19
@InsomniaCoder InsomniaCoder requested a review from a team as a code owner April 23, 2024 21:19
@InsomniaCoder
Copy link
Contributor Author

closing to combine all changes in the main PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant