fix(helm): fix queryScheduler servicemonitor #12753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rlex
changed the title
|
Please also bump the version number in |
|
done |
|
Any chance it will be merged? Along with #12766 |
MichelHollands
approved these changes
May 24, 2024
yoyosir
reviewed
May 28, 2024
| @@ -21,7 +21,7 @@ spec: | |||
| ports: | |||
| - name: http-metrics | |||
| port: 3100 | |||
| targetPort: http | |||
| targetPort: http-metrics | |||
There was a problem hiding this comment.
Do we have the same issue for service-query-frontend-headless.yaml?
There was a problem hiding this comment.
1ab9d27 looks like it was fixed just recently
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Loki Query Scheduler had wrong targetPort for metrics port, which caused serviceMonitor to miss it.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR