fix(nix): lambda-promtail vendor hash #12763
Conversation
| @@ -63,7 +63,7 @@ func (p *processor) runWithBounds(ctx context.Context, tasks []Task, bounds v1.M | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *processor) processTasks(ctx context.Context, tenant string, day config.DayTime, keyspaces v1.MultiFingerprintBounds, tasks []Task) error { | |||
There was a problem hiding this comment.
I don't think a change here was intended?
There was a problem hiding this comment.
It was, the linter fails on the unused parameter
There was a problem hiding this comment.
nevermind, I missed that this was also failing the same Nix linting job
how was it not failing any other linting jobs?
There was a problem hiding this comment.
I haven't quite got to the bottom of that, but it has something to do with how we only lint on changes (vs nix build linting on everything because there's not concept of version control in the nix build). however, that means these changes do sneak through somehow, and that's the part I haven't figured out. something small like this pops up on almost every small nix PR like this.
There was a problem hiding this comment.
strange, I still would have assumed the regular golangci-lint job would have failed on the PR that originally added this LOC
What this PR does / why we need it:
Fixes the vendor hash for lamda-promtail, looks like the deps have been updated.