Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): use correct GEL image tag and set enterprise gateway proxy URLs for SSD #12847

Closed
wants to merge 2 commits into from

Conversation

monodot
Copy link
Contributor

@monodot monodot commented May 1, 2024

What this PR does / why we need it:
Updates the image tag referenced in the deployment to 3.0.0 (without the v prefix) and adds a set of downstream proxy URLs in the enterprise-gateway that support SSD mode (so that the Ring Health tab in the Grafana Enterprise Logs plugin is able to list the nodes).

Which issue(s) this PR fixes:
Fixes #12845

Also uses the bucket name provided in loki.storage.bucketNames.admin, instead of the hardcoded Admin bucket name admin.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented May 1, 2024

CLA assistant check
All committers have signed the CLA.

@monodot monodot closed this May 3, 2024
@monodot monodot deleted the gel3-helm branch May 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart is using wrong image tag and proxy config for GEL in SSD mode
2 participants