feat(detectedFields): Support multiple parsers to be returned for a single field #12899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
approved these changes
May 6, 2024
| for _, v := range vals { | ||
| parsedFields := detectedFields[k] | ||
| if !parsedFields.isTypeDetected { | ||
| if detectType { |
There was a problem hiding this comment.
this is tricky. just to be clear, the assumption here is that fields in the same stream will have the same type, but fields in different streams may have different types which is why we only include the default "string" type logic in the merge code?
I think that's probably a safe assumption, and it save us from having to run the determine type logic on every line, but I want to make sure it's clear to future readers the assumption we're making.
There was a problem hiding this comment.
Agree, added a comment!
This was referenced May 13, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Detected fields across different streams can require different parsers, thus this PR changes the
parserproperty to aparsers: []stringproperty.Furthermore, if multiple fields with the same label/name are detected but different types, we set that to
stringnow.Special notes for your reviewer:
I removed the
parsedFields.isTypeDetectedproperty and will just detect the type for each new stream, as this is most likely to differ there. Let me know if you think that should change.