Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Introduce feature flag for [last|first]_over_time sharding. #13067

Merged
merged 1 commit into from
May 29, 2024

Conversation

jeschkies
Copy link
Contributor

@jeschkies jeschkies commented May 29, 2024

What this PR does / why we need it:
last_over_time and first_over_time sharding which was introduced with k202 requires protobuf encoding. This change introduces a feature flag for the sharding so that it's not applied when json encoding is used.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jeschkies jeschkies marked this pull request as ready for review May 29, 2024 14:33
@jeschkies jeschkies requested a review from a team as a code owner May 29, 2024 14:33
@grafanabot
Copy link
Collaborator

Hello @jeschkies!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@jeschkies jeschkies added the type/bug Somehing is not working as expected label May 29, 2024
@jeschkies jeschkies changed the title feat: Introduce feature flag for [last|first]_over_time sharding. fix: Introduce feature flag for [last|first]_over_time sharding. May 29, 2024
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@jeschkies jeschkies force-pushed the karsten/last-over-time-feature branch from 49b4ce1 to a5bc894 Compare May 29, 2024 14:41
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 29, 2024
Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome. thanks @jeschkies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k202 backport k203 backport k204 size/M type/bug Somehing is not working as expected type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants