-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Introduce feature flag for [last|first]_over_time sharding. #13067
fix: Introduce feature flag for [last|first]_over_time sharding. #13067
Conversation
Hello @jeschkies!
Please, if the current pull request addresses a bug fix, label it with the |
This PR must be merged before a backport PR will be created. |
49b4ce1
to
a5bc894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome. thanks @jeschkies
) (cherry picked from commit 6e45550)
) (cherry picked from commit 6e45550)
) (cherry picked from commit 6e45550)
What this PR does / why we need it:
last_over_time
andfirst_over_time
sharding which was introduced with k202 requires protobuf encoding. This change introduces a feature flag for the sharding so that it's not applied whenjson
encoding is used.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR