Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blooms): Some boom gateway cleanups #13165

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Jun 7, 2024

What this PR does / why we need it:

  • Cleanup logic for processing multiple days
    in single FilterChunkRefs request in the bloom gateway. The handler
    already returned an error if the requested chunk refs spanned across
    multiple days, but the logic for processing multiple days/tasks was
    still in place. This commit simplifies the logic to only process a
    single task per request.

  • Remove unused package global variable

  • Remove bloomgateway package comment

  • Remove duplicate imports

  • Avoid conversion from *logproto.ShortRef to v1.ChunkRef
    and istead cast the value of the pointer

  • Simplify getFromThrough() function

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum force-pushed the chaudum/bloomgateway-cleanups branch 2 times, most recently from 7795e35 to 37ac2da Compare June 7, 2024 09:44
@chaudum chaudum marked this pull request as ready for review June 7, 2024 09:45
@chaudum chaudum requested a review from a team as a code owner June 7, 2024 09:45
@chaudum chaudum force-pushed the chaudum/bloomgateway-cleanups branch 2 times, most recently from 7bdc6ae to caac1d9 Compare June 7, 2024 13:50
Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any issues ;) LGTM

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
and istead cast the value of the pointer

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
in single `FilterChunkRefs` request in the bloom gateway. The handler
already returned an error if the requested chunk refs spanned across
multiple days, but the logic for processing multiple days/tasks was
still in place. This commit simplifies the logic to only process a
single task per request.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/bloomgateway-cleanups branch from c56838d to 280648a Compare June 10, 2024 11:47
@chaudum chaudum enabled auto-merge (squash) June 10, 2024 11:47
@chaudum chaudum merged commit d4fcef5 into main Jun 10, 2024
59 checks passed
@chaudum chaudum deleted the chaudum/bloomgateway-cleanups branch June 10, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants