fix: errors reported by the race detector #13174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuUsage remains as a global variable, but it is implemented using atomic values. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Use two different variables to silence the report. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
With a Mutex. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
With an atomic variable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Avoid changing a global variable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
We cannot share querier or block objects across goroutines, because they have state that is updated. Instead, copy the blocks and create a new querier each time the mock `FetchBlocks` is called. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Give everyone their own variable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Using an atomic variable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Using atomic variables. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This was referenced Jun 17, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Race conditions lead to hard-to-understand bugs in production.
While nearly all the code touched by this PR is for tests or diagnostics, it is a great help to run the race detector regularly, to avoid new races being added in production.
All tests now pass on my local machine with
-race, apart from:TestOwnsRetention/multiple_compactors, which fails with "Condition never satisfied"TestGenerateDataSizeis extremely slow under the race detector, taking ~10 minutes on my machine. Perhaps it should use smaller payloads?Which issue(s) this PR fixes:
Fixes #8586
Special notes for your reviewer:
This PR is broken down into individual commits; it will be easier to review one at a time.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR