Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(helm): Fix broken Values.yaml link in the examples docs #13219

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

javiergarea
Copy link
Contributor

What this PR does / why we need it:
The links to the Values.yaml file in the example documentation point to an obsolete reference. This PR updates these links to target the new location.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:
n/a

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@javiergarea javiergarea requested a review from a team as a code owner June 14, 2024 10:12
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024

CLA assistant check
All committers have signed the CLA.

@javiergarea javiergarea changed the title docs(helm): Fix broken values.yaml link in the examples docs docs(helm): Fix broken Values.yaml link in the examples docs Jun 14, 2024
@jeschkies jeschkies enabled auto-merge (squash) June 14, 2024 12:36
@jeschkies jeschkies merged commit 9a99b05 into grafana:main Jun 14, 2024
60 of 61 checks passed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants