Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pattern ingesters add a limiter for high eviction rate #13464

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This automatically throttle streams with high eviction rate (>25% of added sample).

Also reduce pruning ticker and chunk range which allows for more granular pruning but also create smaller chunks for idle patterns.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@cyriltovena cyriltovena requested a review from a team as a code owner July 9, 2024 13:49
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 9, 2024
Copy link
Contributor

@benclive benclive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, otherwise LGTM

}

func (l *limiter) block() {
l.blockedUntil = time.Now().Add(10 * time.Minute)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about sampling instead of blocking completely for some time?
We could accept a small %age of the writes to keep building patterns. It might make a nicer experience for the user?

Copy link
Contributor Author

@cyriltovena cyriltovena Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's good suggestion. I would like to keep it that way for now until we have all clusters under control and then improve this later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare in mind that it will still grow the tree if we do sampling. So I think it's a bit more risky.

In this case it will constantly lock the streams if it keeps evicting.

@cyriltovena cyriltovena merged commit e08b4a7 into main Jul 9, 2024
62 checks passed
@cyriltovena cyriltovena deleted the lockdown-eviction branch July 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants