Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement GetObjectRange for all storage providers #13650

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:

  • For RF-1 project, adding GetObjectRange API to all the object stores.
  • This just uses whatever the native feature is (normally HTTP Range header) to fetch part of the object instead of the whole thing.
  • HTTP range headers are fully inclusive compared to Go's slices, for example, so thats a small gotcha.
  • I don't know if we want to track the fetch metrics under a different name or not, because they're all parameters to the regular GetObject call in each case.

@benclive benclive requested a review from a team as a code owner July 24, 2024 16:01
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benclive benclive merged commit d9c441e into main Jul 24, 2024
61 checks passed
@benclive benclive deleted the benclive/implement-getobjectrange-for-storage branch July 24, 2024 17:25
benclive added a commit to cyriltovena/loki that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants