chore(lint-error): remove unused stepCount in engine.go
#13709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may block any PRs to merge because it causes following failure in CI checks ``` INFO [runner] linters took 59.237147569s with stages: goanalysis_metalinter: 58.68919861s pkg/logql/engine.go:449:3: ineffectual assignment to stepCount (ineffassign) stepCount = 1 ^ ``` This PR removes the unused `stepCount` Signed-off-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Recent PR removed the usage
stepCount. But not the assignment, causing some CI checks to failThis may block any PRs to merge
This PR removes the unused
stepCountWhich issue(s) this PR fixes:
Fixes #NA
Special notes for your reviewer:
Blocks PR to be merged. e.g: #11132
Checklist
CONTRIBUTING.mdguide (required)