-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-promtail): build lambda with zip file #13787
feat(lambda-promtail): build lambda with zip file #13787
Conversation
Hey @maxforasteiro . There are a lot of users who already use lamda promatail in the way it was before. |
Hey @vlad-diachenko, thanks for the quick code review! I just added the ability to either pass the image tag or generate it from the repo itself if it is absent. |
|
hey @vlad-diachenko! can you take a look now? |
sure, I will review it today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. thanks @maxforasteiro
What this PR does / why we need it:
Avoid having to create ECRs repos and building image with terraform instead.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is my first contribution. Let me know if there's anything else I can do to get this pushed to main. Our idea is to use
tools/lambda-promtail
as a module from our IaC without any extra steps. We have already implemented and tested a similar solution in our IaC and it works.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR