Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basic multiline support based on stage-chains idea #1380

Closed
wants to merge 5 commits into from
Closed

Added basic multiline support based on stage-chains idea #1380

wants to merge 5 commits into from

Commits on Dec 5, 2019

  1. pkg/logentry/stages: Stage must call next stage to continue processing 

    Stage can now decide whether processing should continue or not by
calling or not calling next stage in the chain.

This allows implementing more complex stages, eg. multiline stage.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    1e1dfb5 View commit details
    Browse the repository at this point in the history

  2. pkg/logentry/stages: benchmark tricks 

    Don't use new pipelineChain for each stage, reuse existing one.
Don't call time.Since if not needed.
Don't allocate new resultChain for each benchmark iteration.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    a73d84b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. pkg/logentry/stages: basic multiline support 

    - no flush or timeout yet, only first line regex

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    ba09885 View commit details
    Browse the repository at this point in the history

  2. pkg/logentry/stages: basic multiline support 

    If line doesn't match firstline, but there is no buffered firstline, just pass it forward.
Also added some extra details to buffered entries.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    f99e4a9 View commit details
    Browse the repository at this point in the history

  3. pkg/logentry/stages: basic multiline support 

    Added flushing of buffered multilines.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    d8abb9e View commit details
    Browse the repository at this point in the history