Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-3.1.x] fix(ci): fixed release-please manifest #13811

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport f253db5 from #13810


What this PR does / why we need it:
bumped the version in release please manifest to point release-please github action to the correct latest version.

Context:
During releasing the patch version of 3.1.x release, our CI automation created wrong release PR that contains diff since 3.0.0 release. See: PR

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
(cherry picked from commit f253db5)
@grafanabot grafanabot requested a review from a team as a code owner August 8, 2024 14:13
@grafanabot grafanabot added backport type/bug Somehing is not working as expected type/ci labels Aug 8, 2024
Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! happy to approve it

@vlad-diachenko vlad-diachenko merged commit 89fe788 into release-3.1.x Aug 8, 2024
64 checks passed
@vlad-diachenko vlad-diachenko deleted the backport-13810-to-release-3.1.x branch August 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/bug Somehing is not working as expected type/ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants