feat: add _extracted suffix to detected fields conflicts #13993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detected fields that conflict with indexed labels need the "extracted" suffix
svennergr
reviewed
Aug 28, 2024
There was a problem hiding this comment.
The parser will already add the suffix if it's part of the "base labels" passed to it:
https://github.com/grafana/loki/blob/main/pkg/logql/log/parser.go#L329
What if we just get all stream labels as LabelsBuilder and pass that via parseLine to the logFmtParser.Process and jsonParser.Process calls to let them handle adding the suffix?
I think that might be a bit better since adding the suffix would stay in one place.
this avoids an extra iteration over streams
svennergr
reviewed
Aug 29, 2024
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Because the front end will pass field names directly from the
/detected_fieldscall to asum by()clause in the metric query, we need to differentiate fields that conflict with indexed labels by adding the "extracted" suffix