Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k218] chore(deps): Downgrade fake-gcs-server #14085

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

trevorwhitney
Copy link
Collaborator

Backport 20ac1ba from #14078


What this PR does / why we need it:
A previous upgrade of fake-gcs-server has resulting in failures during the dist steps of our releases.

This PR reverts the upgrade of the fake-gcs-server from the original PR, but keeps the upgraded libraries.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
(cherry picked from commit 20ac1ba)
@trevorwhitney trevorwhitney added size/M backport type/bug Somehing is not working as expected product-approved labels Sep 9, 2024
@trevorwhitney trevorwhitney requested a review from a team as a code owner September 9, 2024 19:42
@trevorwhitney trevorwhitney merged commit 6d3efa0 into k218 Sep 9, 2024
64 checks passed
@trevorwhitney trevorwhitney deleted the backport-14078-to-k218 branch September 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport product-approved size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants