Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [k218] docs: add X-Scope-OrgID header to Grafana datasource if multi-tenancy is enabled #14172

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: [k218] docs: add X-Scope-OrgID header to Grafana datasource if multi-tenancy is enabled #14172

merged 1 commit into from
Sep 18, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Sep 18, 2024

Backport f4da88e from #13914

What this PR does / why we need it:

This PR updates the Visualize Grafana doc to include instructions for adding Loki datasource when multi-tenancy is enabled.

Which issue(s) this PR fixes:

Fixes #13179. Well, the OP for this issue hasn't confirmed the fix, but I ran into a similar issue and did notice the docs were missing this key info. I'm happy to open a new issue if that makes more sense.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jonathanfoster @grafana-delivery-bot
docs: add X-Scope-OrgID header to Grafana datasource if multi-tenan…
f99ac4e 
…cy is enabled (#13914)

Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit f4da88e)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner September 18, 2024 15:51
@loki-gh-app loki-gh-app bot added backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Sep 18, 2024
@JStickler JStickler merged commit 659f542 into k218 Sep 18, 2024
61 of 64 checks passed
@JStickler JStickler deleted the backport-13914-to-k218 branch September 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@trevorwhitney trevorwhitney Awaiting requested review from trevorwhitney

Assignees
No one assigned
Labels
backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JStickler @jonathanfoster