pkg/ingester: Added possibility to disable transfers. #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, with -ingester.max-transfer-retries set to zero, transfers would never stop. Now zero means don't transfer at all. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
rfratto
added a commit
that referenced
this pull request
Jan 24, 2020
#1425 added the ability to disable transfers by setting the max amount of retries to zero or lower. The PR, however, didn't change the default setting in loki-local-config.yaml. This commit changes the setting in loki-local-config.yaml to disable transfers since they would never succeed with the default settings of an inmemory ring anyway.
cyriltovena
pushed a commit
that referenced
this pull request
Jan 24, 2020
* Disable transfers in loki-local-config.yaml #1425 added the ability to disable transfers by setting the max amount of retries to zero or lower. The PR, however, didn't change the default setting in loki-local-config.yaml. This commit changes the setting in loki-local-config.yaml to disable transfers since they would never succeed with the default settings of an inmemory ring anyway. * Set `max_transfer_retries` to 0 in helm charts
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* Disable transfers in loki-local-config.yaml grafana#1425 added the ability to disable transfers by setting the max amount of retries to zero or lower. The PR, however, didn't change the default setting in loki-local-config.yaml. This commit changes the setting in loki-local-config.yaml to disable transfers since they would never succeed with the default settings of an inmemory ring anyway. * Set `max_transfer_retries` to 0 in helm charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, with -ingester.max-transfer-retries set to zero, transfers would never stop. Now zero means don't transfer at all.
Note: this is in line with how Cortex works.
Checklist