Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close iterator properly and check nil before releasing buffers. #1480

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Fixes a panic when close is called prior iterating on the chunks. I also realized that some iterator were never closing properly their inner iterator.

@cyriltovena cyriltovena requested review from owen-d and rfratto January 7, 2020 19:41
@cyriltovena
Copy link
Contributor Author

/cc @slim-bean

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/iter/iterator.go Show resolved Hide resolved
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena merged commit be010f0 into grafana:master Jan 8, 2020
@cyriltovena cyriltovena deleted the close-iter branch January 8, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants