Prefetch chunks while processing #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
reviewed
Jan 9, 2020
…such that we aren't waiting for fetches from GCS and spend all our CPU time decompressing and processing Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean
force-pushed
the
pre-fetch-chunks
branch
from
fcbea1c
to
e9acb2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we wait to call next on the batchChunkIterator until we finish processing the current chunk, this means we have to wait for any retrieval time before processing the next chunk.
This change will load the next chunk on a separate thread in the background to make it available immediately after the current chunk is processed.