feat: add per-tenant time sharding for long out-of-order ingestion (backport release-3.3.x) #15482
Conversation
github-actions
bot
added
the
type/docs
| @@ -3723,6 +3723,18 @@ shard_streams: | |||
| # CLI flag: -shard-streams.enabled | |||
| [enabled: <boolean> | default = true] | |||
|
|
|||
| # Automatically shard streams by adding a __time_shard__ label, with values | |||
| # calculated from the log timestamps divided by MaxChunkAge/2. This allows the | |||
| # out-of-order ingestion of very old logs. If both flags are enabled, | |||
There was a problem hiding this comment.
When this says "Both flags" I'm unclear on what the other flag is. Could you please name it to avoid confusion.
There was a problem hiding this comment.
The time-sharding feature depends on the stream-sharding to be enabled (directly above in this view). While I agree that this is a bit intransparent in how it is currently worded, I don't think we should change the text in the backport. This change should be introduced into main first, to avoid reverting back to the old text in the future.
There was a problem hiding this comment.
I didn't notice that this was a backport. I agree, the change should be made in main.
xperimental
changed the title
|
Is there something I need to do, to get this PR moving along? |
|
@xperimental We don't usually backport code for features, usually just bugs. This particular code will be part of the next release, which should be coming in the next 30 days or so. Can you wait until the next release? |
What this PR does / why we need it:
This is a backport of #14711 to
release-3.3.x.Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)